Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/739 - Account module migrated from identity to state #773

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Feature/739 - Account module migrated from identity to state #773

merged 1 commit into from
Dec 13, 2023

Conversation

Ybittan
Copy link
Member

@Ybittan Ybittan commented Dec 11, 2023

Description

Account module migrated from identity to state

Related Issue

#739

Motivation and Context

BpiAccounts are about the state, not identity, so the AccountModule should reside in the state folder.

How Has This Been Tested

npm run test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

@Ybittan Ybittan mentioned this pull request Dec 11, 2023
Closed
1 task
Therecanbeonlyone1969
Therecanbeonlyone1969 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Therecanbeonlyone1969 Therecanbeonlyone1969 merged commit bde1836 into main Dec 13, 2023
1 check passed
@Therecanbeonlyone1969 Therecanbeonlyone1969 deleted the feature/739-SRI-folder-migration branch December 13, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 approved these changes

@skosito skosito skosito approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14 skarred14 is a code owner

@ognjenkurtic ognjenkurtic Awaiting requested review from ognjenkurtic ognjenkurtic is a code owner

@Kasshern Kasshern Awaiting requested review from Kasshern Kasshern is a code owner

@biscuitdey biscuitdey Awaiting requested review from biscuitdey biscuitdey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ybittan @skosito @Therecanbeonlyone1969